Skip to content

Show break type expectation cause for let-else #151854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 30, 2026
Merged

Show break type expectation cause for let-else #151854

rust-bors merged 1 commit into from
Jan 30, 2026
+52 −0

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Jan 30, 2026 •
edited by rustbot
Loading

Fixes #142602

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 30, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2026

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Kivooeo
Copy link
Member

Kivooeo commented Jan 30, 2026

looks amazing, thanks!

r? me

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 30, 2026

📌 Commit 9c135ad has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 30, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 30, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 30, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 30, 2026
@bors
Auto merge of #151860 - JonathanBrouwer:rollup-FqYVDlY, r=JonathanBro…
36e2b8a 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #151376 (Fix performance issue in liveness checking)
 - #151851 (Remove redundant `IntoQueryParam` calls from query plumbing)
 - #151854 (Show break type expectation cause for let-else)
 - #151859 (Disable append-elements.rs test with debug assertions)
@rust-bors rust-bors bot merged commit b243d01 into rust-lang:main Jan 30, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 30, 2026
rust-timer added a commit that referenced this pull request Jan 30, 2026
@rust-timer
Unrolled build for #151854
d8f08ff 
Rollup merge of #151854 - chenyukang:yukang-fix-142602-let-else-break-diag, r=Kivooeo

Show break type expectation cause for let-else

Fixes #142602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

E0308 doesn't provide a help message in loops when using let-else

4 participants

@chenyukang @rustbot @Kivooeo @davidtwco